This repository was archived by the owner on Feb 4, 2022. It is now read-only.
fix(pool): don't try to reconnect if initial connection fails #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automattic/mongoose#6670 seems to be another instance of the issue I mentioned in #275: if initial connection fails, the driver will keep trying to reconnect in the background. So users that retry
MongoClient.connect()
when initial connection fails get a bunch of zombie database connections (one might call them "dead pools" :) ) if one of their reconnect tries succeeds. For example, try running this code against a standalone server that isn't running, and then start it after 10 seconds, you'll see 11 connections rather than 1.Just wanted to put this issue out there and suggest a potential fix. We need a consistent explanation for how to handle initial connection failures: either the driver will keep trying to reconnect, or the user should try to reconnect on their own. Right now we generally recommend the latter, but the code does a little bit of both the latter and the former.